feat: use async_timeout instead of asyncio.wait_for #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids creating a task which will make it easier to trace down races in the aio message_bus write_callback
Codecov ReportBase: 81.03% // Head: 81.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 81.03% 81.15% +0.11%
==========================================
Files 24 24
Lines 2869 2871 +2
Branches 626 627 +1
==========================================
+ Hits 2325 2330 +5
+ Misses 335 332 -3
Partials 209 209
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdegat01
approved these changes
Sep 26, 2022
dlech
reviewed
Sep 26, 2022
bdraco
added a commit
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids creating a task which will make it easier
to trace down races in the aio message_bus write_callback
We currently have a race (maybe destruction race) in
dbus-fast/src/dbus_fast/aio/message_bus.py
Line 78 in d71f0e1
where somehow
self.bufisNone